President gives information to Russia

Given the qualifiers you've put on this hypothetical scenario, I would say "no." I would have said "yes" with the following modifications.
1. Remove "hostile" nations. In my judgement, there are no assurances that an adversary will use the shared information to stop a terrorist attack. They might use it instead to compromise our intelligence gathering or that of our allies. Once that information is released, we have no control over how an enemy nation might use it.
2. Include a provision that information should only be shared after consultation with the U.S. intelligence community and, if the information came from an ally, after that ally approves the sharing of the information.

Now, let me comment on the specific incident involving Dolt 45 last week. First, why was the Russian press allowed to attend this meeting but the U.S. press was not? Why would a known Russian spy, this fellow Kislyak, be invited to the Oval Office? It didn't take very long for the source of the intelligence, Israel, to be identified and the potential for adverse impacts on their intelligence gathering is considerable. This is a situation that could literally cost operatives and their families their lives. I would ask why he felt sharing this information with the Russians was a good idea. The only answer I can come up with at this time is "because he could."

The POTUS is sworn to protect the citizens of this country, so I think that national security issues should have the highest priority when such actions are being contemplated.

What you propose is a commonsense approach to this question. Unfortunately, common sense seems in short supply in D.C. As you correctly note, these are very strange times that we are living in. I'm curious as to whether or not you think 45 will make it through his term.